validate ids prior to using as seed for transmission schedule #14116
Conversation
| ) | ||
|
|
||
| // Workflow IDs and Execution IDs are 32-byte hex-encoded strings | ||
| func ValidateWorkflowOrExecutionID(id string) error { |
There was a problem hiding this comment.
Do you mind keeping it in utils.go? Or alternatively moving all the validators to validation.go and their tests to validation_test.go? We are now in a messy state where some methods are here and some there... My preference is to keep stuff in utils.go as it minimizes the total amount of changes needed.
There was a problem hiding this comment.
ah crap, yeah I should have at least moved the corresponding tests, my bad. The utils stuff is used outside of the remote package as well now so should sit outside that, I'll tidy it up
There was a problem hiding this comment.
I've moved the validation logic used in remote and other packages in capabilities into validation package along with the corresponding tests. All other logic that is used only in remote package has been kept in the remote/utils.go file.
ettec
force-pushed
the
ks-404
branch
2 times, most recently
from
6afe791
to
8116158
Compare
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
resolves-> https://smartcontract-it.atlassian.net/browse/KS-404